<html>
<head><meta charset="utf-8"><title>I-prioritize #78474 `unconditional_recursion` lint doesn&#x27;t … · t-compiler/wg-prioritization/alerts · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/index.html">t-compiler/wg-prioritization/alerts</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html">I-prioritize #78474 `unconditional_recursion` lint doesn&#x27;t …</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214823458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214823458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214823458">(Oct 28 2020 at 11:28)</a>:</h4>
<p><span class="user-group-mention" data-user-group-id="3111">@WG-prioritization/alerts</span> issue <a href="https://github.com/rust-lang/rust/issues/78474">#78474</a> has been requested for prioritization.</p>
<h1><a href="https://forge.rust-lang.org/compiler/prioritization/procedure.html#assign-priority-to-unprioritized-issues-with-i-prioritize-label">Procedure</a></h1>
<ul>
<li>Priority?</li>
<li>Regression?</li>
<li>Notify people/groups?</li>
<li>Needs <code>I-nominated</code>?</li>
</ul>



<a name="214823568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214823568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Hameer Abbasi <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214823568">(Oct 28 2020 at 11:29)</a>:</h4>
<p><code>P-medium</code>, maybe <code>P-high</code>, missing warning on obvious infinite recursion, regression from stable to stable.</p>



<a name="214823735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214823735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214823735">(Oct 28 2020 at 11:31)</a>:</h4>
<p>I'd say <code>P-medium</code>, too</p>



<a name="214824618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214824618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> James Gill <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214824618">(Oct 28 2020 at 11:42)</a>:</h4>
<p>Just saw that <span class="user-mention" data-user-id="211727">@Jonas Schievink</span> comment saying it was expected behaviour. In this case I assume if it would still be correct to fix, as it was intentional would <code>P-low</code> be more appropriate?</p>



<a name="214828971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214828971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214828971">(Oct 28 2020 at 12:29)</a>:</h4>
<p>I think <code>P-medium</code> is fine. If this behavior is intentional it would make more sense to just close this, wouldn't it <span aria-label="thinking" class="emoji emoji-1f914" role="img" title="thinking">:thinking:</span></p>



<a name="214854675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214854675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214854675">(Oct 28 2020 at 15:41)</a>:</h4>
<p>just want to say recursion may not always be obvious (it in this case because it is a simplified example)</p>



<a name="214860475"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214860475" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214860475">(Oct 28 2020 at 16:17)</a>:</h4>
<p>The linked issue confuses me :/ I'm not sure why it was changed</p>



<a name="214860707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214860707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214860707">(Oct 28 2020 at 16:19)</a>:</h4>
<p><code>f()</code> can panic, so <code>foo()</code> might now necessarily recurse here</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="k">fn</span> <span class="nf">foo</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="n">f</span><span class="p">();</span><span class="w"></span>
<span class="w">    </span><span class="n">foo</span><span class="p">();</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="214860745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214860745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214860745">(Oct 28 2020 at 16:19)</a>:</h4>
<p>which we now consider when linting <code>unconditional_recursion</code></p>



<a name="214860820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214860820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214860820">(Oct 28 2020 at 16:20)</a>:</h4>
<p><em>but imo should not</em></p>



<a name="214864100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214864100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214864100">(Oct 28 2020 at 16:42)</a>:</h4>
<p>right, I understand why it's <em>possible</em>, I just think the lint should still fire</p>



<a name="214864150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214864150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214864150">(Oct 28 2020 at 16:43)</a>:</h4>
<p>the example didn't seem very convincing of <em>why</em> you'd want to want to ignore that case</p>



<a name="214883928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214883928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214883928">(Oct 28 2020 at 19:06)</a>:</h4>
<p>I guess I'd go with <code>P-medium</code> for this one</p>



<a name="214883952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214883952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214883952">(Oct 28 2020 at 19:07)</a>:</h4>
<p>given that some people already said <code>P-medium</code> tagging it like so but feel free to comment if you want to change prio</p>



<a name="214884021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize%20%2378474%20%60unconditional_recursion%60%20lint%20doesn%27t%20%E2%80%A6/near/214884021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> triagebot <a href="https://rust-lang.github.io/zulip_archive/stream/245100-t-compiler/wg-prioritization/alerts/topic/I-prioritize.20.2378474.20.60unconditional_recursion.60.20lint.20doesn&#x27;t.20.E2.80.A6.html#214884021">(Oct 28 2020 at 19:08)</a>:</h4>
<p>Issue <a href="https://github.com/rust-lang/rust/issues/78474">#78474</a>'s prioritization request has been removed.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>